Prevent Parsing of attachments #183
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
May 31, 2017 12:31
This causes an issue when the subpart is an attachment that is an RFC822 file. This resolves this issue.
Fix syntax error I didn't notice till too late
barbushin
requested changes
Aug 23, 2017
src/PhpImap/Mailbox.php
Outdated
| protected $imapParams = array(); | ||
| protected $serverEncoding; | ||
| protected $attachmentsDir = null; | ||
| protected $sDir = null; |
There was a problem hiding this comment.
What needs fixing? Not sure...
There was a problem hiding this comment.
@duper51 What is protected $sDir = null; for? It must be deleted.
barbushin
added
the
question
|
@barbushin must have been a remnant of my testing of this feature. Removed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current version of PHP-Imap does not check if a part is an attachment, and thus will parse an RFC822 compliant file. I don't believe this to be the intended behavior.